Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): Make lint mandatory for UI package #360

Merged
merged 2 commits into from
Nov 17, 2023
Merged

chore(lint): Make lint mandatory for UI package #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef0b5b1
chore(lint): Make lint mandatory for UI package
lordrip Nov 17, 2023
dd2c91b
chore: fix lint error
lordrip Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ jobs:
- name: 💅 Run eslint
run: yarn workspaces foreach --verbose --topological-dev run lint

# Lint style files
- name: 💅 Run stylelint
run: yarn workspace @kaoto-next/ui run lint:style

# Run tests
- name: 🧪 Run tests
run: yarn workspaces foreach --verbose --topological-dev run test
Expand Down
6 changes: 2 additions & 4 deletions packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,8 @@
"preview": "vite preview",
"test": "jest",
"test:watch": "jest --watch",
"lint": "yarn lint:code; yarn lint:style",
"lint:fix": "yarn lint:code:fix; yarn lint:style:fix",
"lint:code": "yarn eslint \"src/**/*.{ts,tsx}\"",
"lint:code:fix": "yarn lint:code --fix",
"lint": "yarn eslint \"src/**/*.{ts,tsx}\"",
"lint:fix": "yarn lint:code --fix",
"lint:style": "yarn stylelint \"src/**/*.{css,scss}\"",
"lint:style:fix": "yarn lint:style --fix"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/ui/src/utils/node-icon-resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import process from '../assets/eip/process.png';
import recipient_list from '../assets/eip/recipient-list.png';
import remove_header from '../assets/eip/removeheader.png';
import remove_headers from '../assets/eip/removeheaders.png';
import remove_property from '../assets/eip/removeproperty.png';
import remove_properties from '../assets/eip/removeproperties.png';
import remove_property from '../assets/eip/removeproperty.png';
import resequence from '../assets/eip/resequence.png';
import rollback from '../assets/eip/rollback.png';
import sample from '../assets/eip/sample.png';
Expand Down Expand Up @@ -689,7 +689,7 @@ function getEIPIcon(elementName?: string): string | undefined {
case 'transform':
return transform;
case 'unmarshal':
return transform;
return transform;
case 'validate':
return validate;
case 'weighted':
Expand All @@ -698,7 +698,7 @@ function getEIPIcon(elementName?: string): string | undefined {
return when;
case 'wireTap':
return wiretap;
default:
default:
return undefined;
}
}
Loading