fix(canvas): Replace nodes that contains a single steps property don't work #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t work Currently, there's a piece of logic that checks if the node meant to be replaced has a single `step` property that can have children. This logic was causing that for some special nodes, like `doCatch`, the replace step functionality didn't work, and the intended replacement step gets appended instead. The fix is to remove said functionality as it was already implemented in a different manner. Fixes: KaotoIO#370
lhein
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's a piece of logic that checks if the node meant to be replaced has a single
stepproperty that can have children. This logic was causing that for some special nodes, likedoCatch, the replace step functionality didn't work, and the intended replacement step gets appended instead.Changes
The fix is to remove said functionality as it was already implemented in a different manner.
Notes
There are more changes to make, as an example,
doCatchanddoFinallyshouldn't be offered as valid EIP if they are not inside of adoTry. Another topic is that special children shouldn't be replaced, for instance,when,otherwise,doCatchanddoFinally.Fixes: #370