fix(canvas): Avoid rerendering the entire application when configuring nodes #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhein
approved these changes
Nov 28, 2023
…g nodes Currently, when configuring a node in the canvas, it refresh the source code. This in turn force rerendering the entire application, as the SourceCode provider holds the source code state and its placed at the root. The fix is to split the provider into SourceCodeContext and SourceCodeApiContext, this way the consumers can subscribe only to the required section avoiding having a reference to the changing source code. A few consumers examples: * FlowClipboard component: it only needs access to the source code. * NewFlow: it only needs access to the SourceCodeApi to signal that something changed * Shell: it only needs access to the `entities:updated` signal to save the code to localStorage * KaotoEditor and SourceCodePage: needs both context Fixes: KaotoIO#213
lordrip
force-pushed
the
fix/avoid-rerendering-when-configuring-node
branch
from
8dc185f to
02b08ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, when configuring a node in the canvas, it refreshes the source code. This in turn forces the rerendering of the entire application, as the SourceCode provider holds the source code state and is placed at the root.
Changes
The fix is to split the provider into SourceCodeContext and SourceCodeApiContext, this way the consumers can subscribe only to the required section avoiding having a reference to the changing source code.
A few consumer examples:
entities:updatedsignal to save the code to localStorageBefore
Updating.entire.UI.webm
After
Screencast.from.2023-11-28.11-31-55.webm
Fixes: #213