fix(ExpressionEditor): Fix stale data in Expression Editor #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the ExpressionEditor and DataFormatEditor hold stale data about the selected node, hence forcing the node update with old data. The issue behaves as the following: 1. The user updates the expression field using the ExpressionEditor 2. After that, a change in an endpoint parameter is made 3. Another update is made in the ExpressionEditor At this point, the ExpressionEditor doesn't know the latest change from the endpoint parameters, hence updating the model with stale information and ignoring the pending changes. The fix is to refresh the data in the ExpressionEditor before making the changes. This issue will behave the same for the `DataFormatEditor` fix: KaotoIO#518
|
Hi @tplevko, I would like to reorder one of our e2e tests to force the reproduction of this issue. Another way could be adding a new test for interacting with the |
lhein
approved these changes
Dec 8, 2023
Hi @lordrip, I will add separate tests for interacting with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ExpressionEditor and DataFormatEditor hold stale data about the selected node, hence forcing the node to update with old data.
The issue behaves as the following:
ExpressionEditorChanges
The fix is to refresh the data in the ExpressionEditor before making the changes.
This issue will behave the same for the
DataFormatEditorfix: #518