Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hash Camel Catalog files #684

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: Hash Camel Catalog files #684

merged 1 commit into from
Jan 22, 2024

Conversation

igarashitm
Copy link
Contributor

Fixes: #680

@@ -29,3 +30,12 @@ const fetchMock = jest.spyOn(window, 'fetch');
beforeEach(() => {
fetchMock.mockResolvedValue(null as unknown as Response);
});

beforeAll(async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for running tests, but yarn build fails saying those variables are not defined.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a look 🆗

Fixes: KaotoIO#680

Now catalog files have MD5 checksum in their file names. In order to resolve catalog file names in Jest tests, fixed those tests to load the catalog through index.json file
@igarashitm igarashitm marked this pull request as ready for review January 19, 2024 20:59
@lordrip lordrip merged commit 4df5160 into KaotoIO:main Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash Camel Catalog files
2 participants