fix(setHeaders): Fix broken setHeaders processor #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changing the way how `AutoForm` updates the node's models, nested schemas, like the one used by `setHeader` no longer work as the key of the property being changed is expressed using the `.` (dot) notation. As an example: `headers.0.expression` This means that we can't use the `key` as it is to set the values, as it won't achieve the expected result. The fix is to use `lodash/set` to navigate through the path and assign the value in the right place. fix: KaotoIO#727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After changing the way how
AutoFormupdates the node's models, nested schemas, like the one used bysetHeaderno longer work as the key of the property being changed is expressed using the.(dot) notation.As an example:
headers.0.expressionThis means that we can't use the
keyas it is to set the values, as it won't achieve the expected result.Changes
The fix is to use
lodash/setto navigate through the path and assign the value in the right place.fix: #727