Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(716): X icon in New Route modal doesn't close the modal #730

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix(716): X icon in New Route modal doesn't close the modal #730

merged 1 commit into from
Jan 25, 2024

Conversation

shivamG640
Copy link
Contributor

fixes #716,

@lhein lhein requested a review from lordrip January 25, 2024 11:43
lordrip
lordrip approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, thanks @shivamG640 👌

@shivamG640
Copy link
Contributor Author

Hi @lordrip ,
There are 4 other models excluding this one and all of them have the onclose property with them!

@lordrip
Copy link
Member

lordrip commented Jan 25, 2024

Hi @lordrip , There are 4 other models excluding this one and all of them have the onclose property with them!

Ah, that's nice to read, cool then, we just had this one 👌

@lhein
Copy link
Contributor

lhein commented Jan 25, 2024

Awesome, thanks for taking care of this, Shivam!

@lordrip lordrip merged commit 93a19cf into KaotoIO:main Jan 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

X icon in New Route modal doesn't close the modal
4 participants
@shivamG640 @lordrip @lhein @Shivam-Gu