-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hint for unknown node type #804
Conversation
Just my 2 cents, I think we should show the information before the node definition, as it might be long and we could miss the explanation. Also, should we use a |
<Card> | ||
<CardHeader> | ||
<CardTitle>Node source</CardTitle> | ||
</CardHeader> | ||
<CardBody> | ||
<CodeBlock> | ||
<CodeBlockCode>{stringify(model)}</CodeBlockCode> | ||
</CodeBlock> | ||
</CardBody> | ||
<CardFooter> | ||
<Hint> | ||
<HintTitle>Node is not a known type</HintTitle> | ||
<HintBody> | ||
Configuration properties are not available when the node is not a known type. Delete, or replace this | ||
node with valid node. | ||
</HintBody> | ||
</Hint> | ||
</CardFooter> | ||
</Card> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this component is starting to grow too big to have here :), maybe it's time to move it to a dedicated file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure - moved to separate file
I'd rephrase the warning message a bit: Unknow node type The configuration for an unknown node cannot be changed in the configuration form. Please switch to the source code and correct the node type. Another option is to replace the step in the graphical editor but in that case you will probably lose the existing configuration. |
you did not change the headline, did you? |
Missed that the headline was also changed - Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good enhancement @tplevko , thanks 💪
fix for #803