Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): Have a static ID for Kamelet #813

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Feb 8, 2024

Context

Currently, the kamelet's storybook example is using a CamelRouteVisualEntity class, and since the JSON example doesn't have an id, an automatic one is provided.

This generates a visual diff every time a new PR is created

The fix is to use the appropriate KameletVisualEntity class so that we could have a static Id for the example

Kamelet's storybook example Visual diff Kamelet using the appropriate class
image image image

@lordrip lordrip requested a review from tplevko February 8, 2024 09:11
@tplevko tplevko merged commit d7dcd47 into KaotoIO:main Feb 8, 2024
9 checks passed
@lordrip lordrip deleted the fix/kamelet-static-id branch February 12, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants