Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CanvasForm): Scrollbar overlapping controls #871

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Feb 26, 2024

Currently, the CanvasForm component shows its scrollbars on top of the form controls, effectively blocking adding or removing elements from an Array.

The fix is to:

  1. Make the <Card> component take the entire height available without scroll
  2. Make the CanvasForm body to have scroll: auto, this way, the scroll bar will be drawn outside of the container, as opposed as it was before, where the form had the scroll

Screenshots

Chrome Firefox Edge
image image image
Before After
image image

fix: #847
fix: #824
fix: #866

Currently, the `CanvasForm` component shows its scrollbars on top of the
form controls, effectively blocking adding or removing elements from an
Array.

The fix is to:
1. Make the `<Card>` component take the entire height available without
   scroll
2. Make the `CanvasForm` body to have `scroll: auto`, this way, the
   scroll bar will be drawn outside of the container, as opposed as it
   was before, where the form had the scroll

fix: KaotoIO#847
fix: KaotoIO#824
Copy link
Contributor

@tplevko tplevko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - looks good.
This also fixes #866

@lordrip lordrip merged commit ea79208 into KaotoIO:main Feb 26, 2024
9 checks passed
@lordrip lordrip deleted the fix/overlapping-scroll branch February 26, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants