fix(catalog): Provide fixed size for Properties Catalog #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Properties Modal size is determined according to its content, meaning that long list will occupy the entire screen while other tabs might be smaller, effectively changing the size and position of the modal. The fix for this is to provide a fixed size for the modal, according to the User's viewport. Ideally, in the future we should transform the properties modal into a page, which will allow the user to share the link to a specific component and properties. Ideally, it should also contain a breadcrumb to show the user current location. fix: KaotoIO#742
tplevko
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Properties Modal size is determined according to its content, meaning that a long list will occupy the entire screen while other tabs might be smaller, effectively changing the size and position of the modal.
The fix for this is to provide a fixed size for the modal, according to the User's viewport.
Ideally, in the future, we should transform the properties modal into a page, which will allow the user to share the link to a specific component and properties. Ideally, it should also contain a breadcrumb to show the user's current location.
Screenshot
720p size
1080p size
1440p size
UHD size (4K)
fix: #742