feat(catalog): Add tile counters #874
Conversation
lordrip
requested review from
lhein and
tplevko
and removed request for
lhein
|
Hi @lordrip, looking at the e2e failures, it seems there is an issue introduced by this PR. It's making it not possible to use filtering using tags: vokoscreenNG-2024-02-27_08-50-52.mp4 |
It looks like just the first tag is honored, I'll check it out |
lordrip
force-pushed
the
feat/add-result-badges-for-catalog
branch
from
af60042 to
1371ebb
Compare
There was a problem hiding this comment.
The changes look good - the test failure seems to be caused by the addition of the debounce, where the cleanup by the reset button doesn't seem to get reflected prior to the next actions with the search field.
The easiest solution would be to add the verification step, to check that the field was indeed cleared.
I think the easiest way to do this is adding this check after the above mentioned lines: cy.get('.pf-v5-c-text-input-group__text-input').should('have.value', '');
Currently, when looking for a `saga` component, we see a `Saga` component, but there's also a `Saga` pattern and there's no visual feedback that it exists, until we click on the `Pattern` toggle. This commit adds counters to each toggle, so we can monitor the occurrences in other groups as well. In addition to that, the lookup is debounced until the user stop writing, in a 500ms window. This helps when writing the first letters of the search term, it doesn't get stuck until the UI renders. The e2e tests for the catalog were updated to include a check after resetting the search field. fix: KaotoIO#745
lordrip
force-pushed
the
feat/add-result-badges-for-catalog
branch
from
1371ebb to
7f2ef77
Compare
Thanks @tplevko, I've updated it according to your suggestion 💪 |
Currently, when looking for a
sagacomponent, we see aSagacomponent, but there's also aSagapattern and there's no visual feedback that it exists until we click on thePatterntoggle.This PR adds counters to each toggle, so we can monitor the occurrences in other groups as well.
In addition to that, the lookup is debounced until the user stops writing, in a 500ms window. This helps when writing the first letters of the search term, it doesn't get stuck until the UI renders.
Screencast
2024-02-26.16-41-27.mp4
fix: #745