Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e - add missing tests for special form fields #912

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Mar 7, 2024

fixes #729

@tplevko tplevko marked this pull request as ready for review March 7, 2024 13:02
@tplevko tplevko requested review from igarashitm and lordrip March 7, 2024 13:02
// cy.get('h4.pf-c-title').should('have.text', "There's no routes to show");
// });
// });
it.skip('User deletes routes in the canvas till there are no routes', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, better to have the skip so we can know how many tests we have under this condition 💪

Comment on lines +72 to +80
Cypress.Commands.add('chooseFromCatalog', (nodeType: string, name: string) => {
cy.get(`[data-testid="${nodeType}-catalog-tab"]`).click();
cy.get('.pf-v5-c-text-input-group__text-input').click();
cy.get('.pf-v5-c-text-input-group__text-input').type(name);
cy.get(`#${name}`).should('be.visible').click();
// wait for the canvas rerender
cy.wait(1000);
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy 👌

@lordrip lordrip merged commit b71c181 into KaotoIO:main Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide e2e tests for special FormFields
3 participants