-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(catalog): Remove single OneOf from AnyOf #949
Conversation
Extract single OneOf definition from AnyOf definition and put it into the root definitions. relates: KaotoIO#948 relates: KaotoIO#560
@@ -51,6 +51,18 @@ public void testProcessSubSchema() throws Exception { | |||
assertEquals("object", beanPropertySchema.get("type").asText()); | |||
} | |||
|
|||
@Test | |||
public void test_extract_single_oneOf_from_anyOf() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe testExtractSingleOneOfFromAnyOf()
- we rarely use C style underscore in Java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented about the test method naming, LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the changes working for the camelYamlDsl-errorHandler
Json.
...atalog-maven-plugin/src/test/java/io/kaoto/camelcatalog/CamelYamlDslSchemaProcessorTest.java
Outdated
Show resolved
Hide resolved
…st/java/io/kaoto/camelcatalog/CamelYamlDslSchemaProcessorTest.java
Extract single OneOf definition from AnyOf definition and put it into the root definitions.
relates: #948
relates: #560