Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog): Remove single OneOf from AnyOf #949

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Mar 15, 2024

Extract single OneOf definition from AnyOf definition and put it into the root definitions.

relates: #948
relates: #560

Extract single OneOf definition from AnyOf definition and put it into the root definitions.

relates: KaotoIO#948
relates: KaotoIO#560
@@ -51,6 +51,18 @@ public void testProcessSubSchema() throws Exception {
assertEquals("object", beanPropertySchema.get("type").asText());
}

@Test
public void test_extract_single_oneOf_from_anyOf() throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe testExtractSingleOneOfFromAnyOf() - we rarely use C style underscore in Java

Copy link
Contributor

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented about the test method naming, LGTM otherwise

Copy link
Contributor

@shivamG640 shivamG640 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the changes working for the camelYamlDsl-errorHandler Json.

…st/java/io/kaoto/camelcatalog/CamelYamlDslSchemaProcessorTest.java
@lordrip lordrip merged commit 658c10c into KaotoIO:main Mar 18, 2024
9 checks passed
@lordrip lordrip deleted the feat/remove-single-anyof branch March 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants