feat(CanvasForm): Add support for ErrorHandler #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/support-error-handler
branch
from
a43a9cd to
786a60c
Compare
lordrip
changed the title
lordrip
commented
Mar 19, 2024
| @@ -53,7 +54,9 @@ export class CamelRouteResource implements CamelResource, BeansAwareResource { | |||
|
|
|||
| getVisualEntities(): CamelRouteVisualEntity[] { | |||
| return this.entities.filter( | |||
| (entity) => entity instanceof CamelRouteVisualEntity || entity instanceof CamelOnExceptionVisualEntity, | |||
| (entity) => | |||
| entity instanceof CamelRouteVisualEntity || | |||
There was a problem hiding this comment.
In the future, the idea is to remove this section by moving CamelRouteVisualEntity to the SUPPORTED_ENTITIES array, this way, we just need to update the SUPPORTED_ENTITIES array whenever there's a new Visual entity to support.
lordrip
commented
Mar 19, 2024
packages/ui/src/models/visualization/flows/camel-error-handler-visual-entity.ts
Show resolved
Hide resolved
lordrip
commented
Mar 19, 2024
lordrip
force-pushed
the
feat/support-error-handler
branch
from
786a60c to
03aa5df
Compare
lordrip
commented
Mar 19, 2024
lordrip
force-pushed
the
feat/support-error-handler
branch
from
03aa5df to
813e266
Compare
Currently, there's partial support for `oneOf` in the `uniforms` library. This commit adds a new `OneOfField` component that shows a selector to pick which schema should the form generate. Also, if a model is already defined, the closest schema is selected automatically. fix: KaotoIO#560 relates: KaotoIO#948
lordrip
force-pushed
the
feat/support-error-handler
branch
from
813e266 to
93f3eec
Compare
tplevko
reviewed
Mar 20, 2024
tplevko
approved these changes
Mar 21, 2024
|
Thanks for reviewing this PR @tplevko 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's partial support for
oneOfin theuniformslibrary.This commit adds a new
OneOfFieldcomponent that shows a selector to pick which schema should the form generate.Also, if a model is already defined, the closest schema is selected automatically.
fix: #560
relates: #948
Reusing the internal ID will be implemented here: #962