Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update typescript #958

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Mar 18, 2024

Currently, the project has 2 different versions of typescript, 5.2.2 and 5.0.4:

├─ @kaoto-next/camel-catalog@workspace:packages/camel-catalog
│  └─ typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441 (via patch:typescript@^5.0.2#~builtin<compat/typescript>)
│
├─ @kaoto-next/ui-tests@workspace:packages/ui-tests
│  └─ typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441 (via patch:typescript@^5.0.2#~builtin<compat/typescript>)
│
├─ @kaoto-next/ui@workspace:packages/ui
│  └─ typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441 (via patch:typescript@^5.0.2#~builtin<compat/typescript>)
│
└─ @microsoft/api-extractor@npm:7.36.4
   └─ typescript@patch:typescript@npm%3A5.0.4#~builtin<compat/typescript>::version=5.0.4&hash=b5f058 (via patch:typescript@~5.0.4#~builtin<compat/typescript>)

This causes to have one behavior in the IDE while having another during compilation time.

The workaround for now is to update typescript to the latest version and provide a resolution so all dependencies uses the same typescript version.

Currently, the project has 2 different versions of `typescript`, `5.2.2`
and `5.0.4`:

```
├─ @kaoto-next/camel-catalog@workspace:packages/camel-catalog
│  └─ typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441 (via patch:typescript@^5.0.2#~builtin<compat/typescript>)
│
├─ @kaoto-next/ui-tests@workspace:packages/ui-tests
│  └─ typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441 (via patch:typescript@^5.0.2#~builtin<compat/typescript>)
│
├─ @kaoto-next/ui@workspace:packages/ui
│  └─ typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441 (via patch:typescript@^5.0.2#~builtin<compat/typescript>)
│
└─ @microsoft/api-extractor@npm:7.36.4
   └─ typescript@patch:typescript@npm%3A5.0.4#~builtin<compat/typescript>::version=5.0.4&hash=b5f058 (via patch:typescript@~5.0.4#~builtin<compat/typescript>)
```

This causes to have one behavior in the IDE while having another during
compilation time.

The workaround for now is to update `typescript` to the latest version
and provide a resolution so all dependencies uses the same `typescript`
version.
@lordrip lordrip merged commit e62ffa9 into KaotoIO:main Mar 18, 2024
9 checks passed
@lordrip lordrip deleted the chore/update-typescript branch March 18, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant