Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide empty implementation for new Channel API relative to metadata an fileContent #657

Merged

Conversation

apupier
Copy link
Member

@apupier apupier commented Sep 16, 2024

relates to KaotoIO/kaoto#1435

Copy link

sonarcloud bot commented Sep 16, 2024

@apupier apupier marked this pull request as ready for review September 16, 2024 14:03
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using vscode.window.showErrorMessage helps to try it out in Kaoto already 👍

i18n: I18n<VsCodeI18n>
) {
super(editor, resourceContentService, workspaceApi, backendProxy, notificationsApi, javaCodeCompletionApi, viewType, i18n);
this.currentEditedDocument = editor.document.document;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[context] I created an issue for this apache/incubator-kie-tools#2584

@apupier apupier merged commit 1393a8a into KaotoIO:main Sep 16, 2024
6 checks passed
@apupier apupier deleted the apiForKaotoMetadataAccess-emptyImplementation branch September 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants