Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid formatting and autogenerate examples #28

Merged
merged 4 commits into from
Jun 5, 2022
Merged

Conversation

yugr
Copy link
Collaborator

@yugr yugr commented May 14, 2022

No description provided.

@yugr yugr added the bug Something isn't working label May 14, 2022
@yugr yugr requested a review from Kazhuu May 14, 2022 10:13
@yugr yugr self-assigned this May 14, 2022
@yugr
Copy link
Collaborator Author

yugr commented May 14, 2022

Looks like installation of dependencies has broken:

  File "/home/runner/.local/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 577, in parse_extras
    self.line, extras = pip_shims.shims._strip_extras(self.line)
TypeError: 'NoneType' object is not callable

@Kazhuu Kazhuu mentioned this pull request May 22, 2022
Copy link
Owner

@Kazhuu Kazhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug! Also the update script is nice and welcome idea. Now that examples files are properly named. Could you delete duplicate pdf files to avoid confusion? Also in the readme there is Examples section describing examples. Could you change the new files name to there as well?

Duplicate pdf files to remove now are 0x555555555faf-0x555555557008.pdf and main.pdf.

I also fixed the pipeline here #29. Rebase or merge to get the errors fixed :)

@Kazhuu Kazhuu linked an issue May 24, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #28 (005c69e) into main (4d90891) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files           4        4           
  Lines         437      437           
=======================================
  Hits          327      327           
  Misses        110      110           
Impacted Files Coverage Δ
src/asm2cfg/asm2cfg.py 77.98% <100.00%> (ø)
src/gdb_asm2cfg.py 75.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d90891...005c69e. Read the comment docs.

@yugr
Copy link
Collaborator Author

yugr commented Jun 4, 2022

Sorry for late update, I've addressed the points from previous review.

Copy link
Owner

@Kazhuu Kazhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks great! Approved and thanks again for contributing 👍

@Kazhuu Kazhuu merged commit 1b80a8b into Kazhuu:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary indent in basic block assembly lines
2 participants