-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid formatting and autogenerate examples #28
Conversation
Looks like installation of dependencies has broken:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the bug! Also the update script is nice and welcome idea. Now that examples files are properly named. Could you delete duplicate pdf files to avoid confusion? Also in the readme there is Examples
section describing examples. Could you change the new files name to there as well?
Duplicate pdf files to remove now are 0x555555555faf-0x555555557008.pdf
and main.pdf
.
I also fixed the pipeline here #29. Rebase or merge to get the errors fixed :)
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 4 4
Lines 437 437
=======================================
Hits 327 327
Misses 110 110
Continue to review full report at Codecov.
|
Sorry for late update, I've addressed the points from previous review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks great! Approved and thanks again for contributing 👍
No description provided.