Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Can't update domains. #43

Open
greyHairChooseLife opened this issue Jan 2, 2025 · 1 comment
Open

[question] Can't update domains. #43

greyHairChooseLife opened this issue Jan 2, 2025 · 1 comment
Labels
question Further information is requested wezterm-issue An issue/bug with WezTerm itself

Comments

@greyHairChooseLife
Copy link

Hello, there!

I apologize in advance for asking a silly question. I am new to the Wezterm so please forgive me.

For testing, I'd updated ssh_domains as follows but didn't notice any difference in the Launcher(mapped to F3 for ShowLauncher).

config/domains.lua
return {
   -- ref: https://wezfurlong.org/wezterm/config/lua/SshDomain.html
   -- ssh_domains = {},
   ssh_domains = {
      -- yazi's image preview on Windows will only work if launched via ssh from WSL
      {
         name = 'wsl.sshhhh',
         remote_address = 'localhost',
         multiplexing = 'None',
         default_prog = { 'fish', '-l' },
         assume_shell = 'Posix',
      },
      {
         name = 'SSH:banana',
         remote_address = 'my.remote.a.ddress',
         username = 'me',
         ssh_option = {
            port = '22',
            identityfile = '~/.ssh/banana-key',
         },
      },
   },

   -- ref: https://wezfurlong.org/wezterm/multiplexing.html#unix-domains
   unix_domains = {},

   -- ref: https://wezfurlong.org/wezterm/config/lua/WslDomain.html
   wsl_domains = {
      {
         name = 'WSL:Ubuntu',
         distribution = 'Ubuntu',
         username = 'kevin',
         default_cwd = '/home/kevin',
         default_prog = { 'fish', '-l' },
      },
   },
}

In the ssh_domains section, there are 2 tables. One is originally configured by this cool repository, and the other is for my testing. Note that I updated the original one's name to 'wsl.sshhhh' from 'wsl.ssh'.

After I saved(automatically_reload_config is true, ofc), I checked ShowLaunch with F3, typed 'domain' for fuzzy matching, and the result was still below:

  • New Tab (domain wsl.ssh)

I wonder why it doesn't display 'wsl.sshhhh' nor show 'SSH:banana'.

@KevinSilvester KevinSilvester added the question Further information is requested label Jan 2, 2025
@KevinSilvester
Copy link
Owner

Hey @greyHairChooseLife,

I was able to replicate this issue on my laptop and it seems to be an issue with all the domains and not just ssh.

Though I'm not sure why the automatic config reloading isn't working for the domains, closing all instances of Wezterm and re-opening the application seems to apply the domain changes correctly.

Hope this helps :)

@KevinSilvester KevinSilvester added the wezterm-issue An issue/bug with WezTerm itself label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wezterm-issue An issue/bug with WezTerm itself
Projects
None yet
Development

No branches or pull requests

2 participants