From f3c3db8c62bec1f2933181ef7262adc233789ae1 Mon Sep 17 00:00:00 2001 From: Ben Kraft Date: Thu, 9 Sep 2021 09:27:52 -0700 Subject: [PATCH] Review comments --- generate/convert.go | 5 ++--- generate/types.go | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/generate/convert.go b/generate/convert.go index e02245e6..75121939 100644 --- a/generate/convert.go +++ b/generate/convert.go @@ -452,9 +452,8 @@ func (g *generator) convertInlineFragment( } // convertFragmentSpread converts a single GraphQL fragment-spread -// (`...MyFragment`) into a Go struct-field. It assumes that -// convertNamedFragment has already been called on the fragment-definition. If -// the fragment does not apply to this type, returns nil. +// (`...MyFragment`) into a Go struct-field. If the fragment does not apply to +// this type, returns nil. // // containingTypedef is as described in convertInlineFragment, above. func (g *generator) convertFragmentSpread( diff --git a/generate/types.go b/generate/types.go index fe04da1f..4ffbd100 100644 --- a/generate/types.go +++ b/generate/types.go @@ -183,7 +183,7 @@ func (typ *goStructType) WriteDefinition(w io.Writer, g *generator) error { // // For embedded fields (from fragments), mostly the JSON library would just // do what we want, but there are two problems. First, if the embedded - // ype has its own UnmarshalJSON, naively that would be promoted to + // type has its own UnmarshalJSON, naively that would be promoted to // become our UnmarshalJSON, which is no good. But we don't want to just // hide that method and inline its fields, either; we need to call its // UnmarshalJSON (on the same object we unmarshal into this struct).