Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config option optional is not validated #255

Closed
benjaminjkraft opened this issue Feb 15, 2023 · 1 comment
Closed

config option optional is not validated #255

benjaminjkraft opened this issue Feb 15, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Issues that anyone could pick up and implement if useful to them

Comments

@benjaminjkraft
Copy link
Collaborator

This option is effectively an enum but right now it's just string-typed, so if you do optional: pointerz it will effectively be equivalent to optional: value (the default). We should validate it!
@benjaminjkraft benjaminjkraft added bug Something isn't working good first issue Good for newcomers help wanted Issues that anyone could pick up and implement if useful to them labels Feb 15, 2023
@DylanRJohnston-FZ
Copy link
Contributor

I've fixed this in #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Issues that anyone could pick up and implement if useful to them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjaminjkraft @DylanRJohnston-FZ