-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How should different screenshot sizes be handled? #49
Comments
@javagl Thank you for taking up this issue.
I use https://github.com/cx20/gltf-test It may be more correct to call it a
Yes, I think it would look better if it were aligned at a fixed fixed width rather than "jagged" as you suggest. |
It would be helpful to write a specification for Perhaps we could specify a minimum resolution of 1280 pixels for the longest dimension, for example 1280x720 which is 720p HD. The guideline for screenshot_large should be added to the new glTF Sample Assets repo, which is in open beta and is meant to supersede the existing glTF Sample Models repo. |
Transferring to Sample Assets so it can be handled there and included in CI. |
Inspired by a comment in a PR:
There is a convention to add a file
/screenshot/screenshot.*
for each model. This screenshot is used as a preview in the table in the main2.0/README.md
file.There are some samples where the screenshot can be pretty small - for example, all the basic
Simple...
models and others. For other screenshots that show nice rendering features, there should be at least one large screenshot that shows the rendered result in high resolution. (Some models already do that, by adding ascreenshot.*
for the preview, and ascreenshot_large.*
to be embedded in the respective README)./screenshot/screenshot.*
file be explicitly required to be a "small" one, with low resolution and file size?I think that one could argue that it should be small, so that the preview page is loaded quickly.
I think that the "jagged" display that results from different-sized screenshots is not so pretty. As an example, showing one table once in the current form and once with fixed image widths:
(This may raise questions about the desired aspect ratio of the screenshots, but I think that fixing the width could make sense...)
The text was updated successfully, but these errors were encountered: