From 36957237c029f9721d6aa2bfb0d2fe1ce6be00e8 Mon Sep 17 00:00:00 2001
From: Pierre Jacquier <pierrejacquier39@gmail.com>
Date: Fri, 3 Jan 2025 12:52:55 -0500
Subject: [PATCH] Louder Windows codesign errors (#4762)

* WIP: Silent failure in signWin.js
Fixes #4582

* Temp: force release build

* Fake throw

* Temp: another test

* Clean up for merge
---
 electron-builder.yml               | 2 +-
 sign-win.js => scripts/sign-win.js | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)
 rename sign-win.js => scripts/sign-win.js (84%)

diff --git a/electron-builder.yml b/electron-builder.yml
index 3559e2d0da..c8bd0d09e7 100644
--- a/electron-builder.yml
+++ b/electron-builder.yml
@@ -38,7 +38,7 @@ win:
     #     - arm64
   signingHashAlgorithms:
     - sha256
-  sign: "./sign-win.js"
+  sign: "./scripts/sign-win.js"
   publisherName: "KittyCAD Inc" # needs to be exactly like on Digicert
   icon: "assets/icon.ico"
   fileAssociations:
diff --git a/sign-win.js b/scripts/sign-win.js
similarity index 84%
rename from sign-win.js
rename to scripts/sign-win.js
index b7280ed038..09e3666d61 100644
--- a/sign-win.js
+++ b/scripts/sign-win.js
@@ -24,8 +24,7 @@ exports.default = async (configuration) => {
 
   try {
     execSync(
-      `smctl sign --fingerprint="${
-        process.env.WINDOWS_CERTIFICATE_THUMBPRINT
+      `smctl sign --fingerprint="${process.env.WINDOWS_CERTIFICATE_THUMBPRINT
       }" --input "${String(configuration.path)}"`,
       {
         stdio: 'inherit',
@@ -33,6 +32,6 @@ exports.default = async (configuration) => {
     )
     console.log('Signing using signWin.js script: successful')
   } catch (error) {
-    console.error('Signing using signWin.js script: failed:', error)
+    throw new Error('Signing using signWin.js script: failed:', error)
   }
 }