Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #8240

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix bug #8240

merged 1 commit into from
Nov 1, 2024

Conversation

xsp1989
Copy link
Contributor

@xsp1989 xsp1989 commented Nov 1, 2024

fix bug

@Koenkk Koenkk merged commit c9e164d into Koenkk:master Nov 1, 2024
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Nov 1, 2024

Could you also submit a picture for the docs? This can be done by:

  1. Create a fork by clicking here
  2. Go to the public/images/devices directory, Add file -> Upload files
  3. Upload the files and press Commit changes
  4. Press Contribute -> Open pull request -> update title/description -> Create pull request

Make sure that:

  • The filename is ZB-RS485.png
  • The size is 512x512
  • The background is transparent (use e.g. Adobe remove background)

@xsp1989
Copy link
Contributor Author

xsp1989 commented Nov 2, 2024

Thank you very much. I have submitted the picture last time, but the model does not correspond to the picture, resulting in the wrong product picture being displayed.

@Koenkk
Copy link
Owner

Koenkk commented Nov 2, 2024

Could you then make a new PR to fix this?

@xsp1989
Copy link
Contributor Author

xsp1989 commented Nov 5, 2024

Could you then make a new PR to fix this?

Do I need to submit a PR again at https://github.com/Koenkk/zigbee2mqtt.io
I changed the model RS485 to ZB-RS485, but the RS485 is displayed on https://www.zigbee2mqtt.io/devices/RS485.html instead of the ZB-RS485.png I submitted.

This is the PR I submitted ZB-RS485.png:
Koenkk/zigbee2mqtt.io@65879aa#diff-638a8f72c86f4fa138e9d177873254dc39c546aac9180e8d115f2251e5a3c74d

How should I fix this bug?

@Koenkk
Copy link
Owner

Koenkk commented Nov 5, 2024

Ah it's correct already, thanks!

@xsp1989
Copy link
Contributor Author

xsp1989 commented Nov 6, 2024

Ah it's correct already, thanks!

Thank you very much for your help, but there are still some problems. I have displayed the correct device in Z2M, but when I click on the device model, the page does not exist. When searching through the manufacturer easyiot, it still shows RS485 instead of ZB-RS485.

This is a wrong model link:
https://www.zigbee2mqtt.io/devices/RS485.html
This is a correct model link, but the corresponding device page cannot be found:
https://www.zigbee2mqtt.io/devices/ZB-RS485.html#easyiot-zb-rs485

@Koenkk
Copy link
Owner

Koenkk commented Nov 6, 2024

That will be fixed with the next z2m release, the change of this PR is not in the z2m release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants