-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivot Release for Core Signing Cert change (macOS) #2453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deps/upgrade-electron
Deploy preview for insomnia-storybook ready! Built with commit 905f5bc |
gschier
changed the title
Core Mac Signing Migration
Pivot Release for Core Signing Cert change (macOS)
Jul 28, 2020
DMarby
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #2451
This PR whitelists Kong's Apple Signing certificate so we can release an update with the new cert later. Electron's built-in updater (Squirrel) will reject the update if next release is signed with a different certificate.
Migration Stages
Release next update with configuration to whitelist new certificateWait long enough until everyone has upgraded to the newest version (probably a couple months).Sign a new release with new certificate and delete whitelist logicsigning-requirements.txt
)Exploration
[updater] Error: Code signature at URL file:///Users/$USER/Library/Caches/com.insomnia.app.ShipIt/update.fhG0QgI/Insomnia.app/ did not pass validation: code failed to satisfy specified code requirement(s)
Resources
Calculating
H"..."
value forsigning-requirements.txt
The instructions provided in the StackOverflow Answer didn't specify how to calculate the SHA1 to whitelist the new certificate, so here are the commands used, for reference.