Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config reader #63

Merged
merged 15 commits into from
Mar 1, 2024
Merged

Add config reader #63

merged 15 commits into from
Mar 1, 2024

Conversation

xxCherry
Copy link
Collaborator

Fixes #57

@cyperdark cyperdark linked an issue Feb 28, 2024 that may be closed by this pull request
Add type of current leaderboard in new route #33
Closed
@cyperdark cyperdark requested a review from KotRikD February 28, 2024 00:32
@cyperdark cyperdark marked this pull request as draft February 28, 2024 18:54
KotRikD
KotRikD requested changes Feb 29, 2024
View reviewed changes
packages/tosu/src/api/types/v2.ts Outdated Show resolved Hide resolved
packages/tosu/src/api/utils/buildResultV2.ts Outdated Show resolved Hide resolved
@cyperdark cyperdark marked this pull request as ready for review March 1, 2024 14:09
KotRikD
KotRikD approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@KotRikD KotRikD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KotRikD KotRikD merged commit 1e03fb6 into master Mar 1, 2024
2 checks passed
@KotRikD KotRikD deleted the config_reader branch March 1, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyperdark cyperdark cyperdark left review comments

@KotRikD KotRikD KotRikD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ingame settings Add type of current leaderboard in new route
3 participants
@xxCherry @cyperdark @KotRikD