Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the optimizers' parameters public #536

Closed
rychuelektryk opened this issue Apr 15, 2023 · 2 comments · Fixed by #538
Closed

Make the optimizers' parameters public #536

rychuelektryk opened this issue Apr 15, 2023 · 2 comments · Fixed by #538
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rychuelektryk
Copy link

Hi,

This is not a big issue, but still I don't see point in making configuration parameters private in optimizers. I would like to log for example what learningrate was set on a specific instance of a optimizer and right now it cannot be done.

@zaleslaw
Copy link
Collaborator

Probably, no reason to keep it private

@zaleslaw zaleslaw self-assigned this Apr 17, 2023
@zaleslaw zaleslaw added the enhancement New feature or request label Apr 17, 2023
@zaleslaw
Copy link
Collaborator

zaleslaw commented Apr 19, 2023

@rychuelektryk what kind of configuration parameters do you mean, something like this?
link to learning rate

@zaleslaw zaleslaw changed the title Please make parameters passed to optimizers public Make the optimizers' parameters public Apr 19, 2023
@zaleslaw zaleslaw added this to the 0.6 milestone Apr 19, 2023
@zaleslaw zaleslaw modified the milestones: 0.6, 0.5.2 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants