Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Investigate the use of GTest in GeoMechanics #11590

Closed
rfaasse opened this issue Sep 22, 2023 · 3 comments
Closed

[GeoMechanicsApplication] Investigate the use of GTest in GeoMechanics #11590

rfaasse opened this issue Sep 22, 2023 · 3 comments
Labels
GeoMechanics Issues related to the GeoMechanicsApplication

Comments

@rfaasse
Copy link
Contributor

rfaasse commented Sep 22, 2023

As a developer, I want to be able to use GTest in my code base, such that I can use all GTest functionality for unit testing

Acceptance criteria

  • The process of adding a Unit Test using GTest in the GeoMechanics suite is understood
  • Knowledge is shared to the team
  • The 'GeoMechanics' specific steps are documented and put on the wiki page.

Note: There should be communication with the CIMNE team, who are looking into implementing GTest for the KratosMultiPhysics suite in general

@rfaasse rfaasse converted this from a draft issue Sep 22, 2023
@rfaasse rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Sep 22, 2023
@indigocoral indigocoral moved this from 📋 Sprint Backlog to 📑 Product Backlog in Kratos Product Backlog Sep 22, 2023
@roigcarlo
Copy link
Member

Hi, we are still having an ongoing effort to makes this done:

  • The main PR accepting GTest as our testing solution is: GTest #11506

Several issues were detected which were covered in:

Currently we are implementing the changes necessary so the MPI tests run. specifically there are two leftover task:

  • Remove the message logging in processes that are not the master.
  • Create a fixture / macro to capture and propagate errors from individual processes to the whole comm, and react only in the master.

@rfaasse
Copy link
Contributor Author

rfaasse commented Sep 26, 2023

Hi Carlos,

Thanks a lot for reaching out and thanks for the info! We are not planning to pick this issue up on the short term (we added it as a reminder that we need to look into it when GTest will become available), but it's very helpful for us to know what is the current status, so feel free to keep us updated on the progress!

FYI @avdg81 @WPK4FEM @indigocoral

@indigocoral indigocoral moved this from 📑 Product Backlog to 📋 Sprint Backlog in Kratos Product Backlog Nov 24, 2023
@rfaasse
Copy link
Contributor Author

rfaasse commented Apr 23, 2024

Closing this issue, as gtest is already added for Kratos as a whole (no separate issue needed)

FYI @mcgicjn2 @avdg81

@rfaasse rfaasse closed this as completed Apr 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Sprint Backlog to ✅ Done in Kratos Product Backlog Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

No branches or pull requests

2 participants