Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StructuralMechanics] Tests Requiring ConstitutiveLawsApp #12160

Closed
matekelemen opened this issue Mar 7, 2024 · 5 comments · Fixed by #12162
Closed

[StructuralMechanics] Tests Requiring ConstitutiveLawsApp #12160

matekelemen opened this issue Mar 7, 2024 · 5 comments · Fixed by #12162
Assignees

Comments

@matekelemen
Copy link
Contributor

The TotalLagrangianMixedVolumetricStrainElementBonetPatch test segfaults if ConstitutiveLawsApplication is not available. @rubenzorrilla can you please fix it and check the rest of the tests in StructuralMechanicsApplication as well?

@loumalouomega
Copy link
Member

With the proper decorator the test can be skipped

@matekelemen
Copy link
Contributor Author

With the proper decorator the test can be skipped

It's a C++ test. Besides, as far as I remember there have been a couple of similar bugs recently, which is why I'm asking Ruben to take a look at his tests.

@loumalouomega
Copy link
Member

With the proper decorator the test can be skipped

It's a C++ test. Besides, as far as I remember there have been a couple of similar bugs recently, which is why I'm asking Ruben to take a look at his tests.

In that case can be skipped iwth a return void if the law is not existing

@rubenzorrilla
Copy link
Member

I'll do it right away following @loumalouomega 's suggestion.

@philbucher
Copy link
Member

C++ tests should not have application dependencies, this was decided long time ago
I recommend to use a python test instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants