[Bug]: AppButton colours don't change while switching themes

[PWagner1]

While testing #1343, it has been discovered that AppButton colours don't change while switching themes. Looks as if it's not repainting somewhere.

[Smurf-IV]

I would expect the following to have an input:

But even when they are empty a colour is still being found from somewhere.

[Smurf-IV]

Narrowed it down to these Palette values:

Nothing to do with the designer values above?!?

[Smurf-IV]

To get this:

Set these things in the designer:

[Smurf-IV]

To get this:

Set the following in the designer:

Which means that the RibbonAppButton is really the QATButton !
So the Explanation text needs to change because changing the Designer text will break all the serialisation of that object !!

[Smurf-IV]

@Wagnerp Proposal:
Because the ##Dark and ##Light values are currently not overridden (Used) in the serialisation of the Palettes:

• Remove from their current "General" location in the designer
• Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton
  • Use the existing values as the defaults, but not "Hard Code" them !
• Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern
• Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values
• Fix Examples
• Fix Theme Template editor
  Thoughts ?

[PWagner1]

@Wagnerp Proposal: Because the ##Dark and ##Light values are currently not overridden (Used) in the serialisation of the Palettes:

• [] Remove from their current "General" location in the designer

• [] Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton

  • Use the existing values as the defaults, but not "Hard Code" them !

• [] Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern

• [] Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values

Thoughts ?

@Smurf-IV Seems fine to me.

[Smurf-IV]

This is happening:

And a new entry for the text (To make it clear what it is!)

[Smurf-IV]

Done so far:

• Remove from their current "General" location in the designer
• Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton
  • Use the existing values as the defaults, but not "Hard Code" them !
• Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern
• Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values
• Fix Examples
• Fix Theme Template editor

[Smurf-IV]

• Remove from their current "General" location in the designer
• Add new Area and values to the State### area with an appropriate named Key: i.e. RibbonFileAppButton
  • Use the existing values as the defaults, but not "Hard Code" them !
• Wire up the usage of Disabled etc usages to use the ##Dark and ##Light overrides to follow the correct pattern
• Update the Breaking Changes area to state correct usages of the RibbonFileAppButton values
• Fix Examples
• Fix Theme Template editor
• [ ]