[Bug]: Todays alpha: Using the Toolkit "TestForm" shows that the drop button icon is not drawn

[Smurf-IV]

[giduac]

Hi @Smurf-IV

Also KDropButton was affected by this and the change to ButtonValues.cs will make KDB behave the same as KButton.
PR underway.

[Smurf-IV]

@Wagnerp Should this go into 8.5 as well ?

[PWagner1]

@Wagnerp Should this go into 8.5 as well ?

@Smurf-IV Yes it should

[Smurf-IV]

@giduac Please recreate the change against the v85 branch and create a PR for that (Also include updates to the changelog)

[giduac]

@Smurf-IV
Can I pop the same commits in there as in alpha ?

[Smurf-IV]

Yes, of course. (If they fit ;-))

[giduac]

Hi @Smurf-IV & @Wagnerp

FYI.
In this fix there will several alterations.
One of the problems with selecting themes are inconsistencies in the order of the PaletteMode Enum and the PaletteModeStrings.SupprotedThemes Dictionary.
This order will be corrected and the SupportedThemes order will be leading.

I would like to ask to make no changes to the two until this issue is complete.

This is the order of the two currently with the discrepancies between the two.

[Smurf-IV]

I prefer the Right list, as it shows the "New" themes being added to the end of the list.
Alphabetical sorting can be done in the combo, as it will still (should) take the tag numbers for the offsets.

[Smurf-IV]

@giduac Also, remember that this has to be placed into 8.5, and still work in V90 without any changes to a designer made with V80 (i.e. enum offsets etc.)

[Smurf-IV]

A Bi-Directional map should take care of identifying what is what (They have been used for other "Sources of truth" as well)

[giduac]

I prefer the Right list, as it shows the "New" themes being added to the end of the list. Alphabetical sorting can be done in the combo, as it will still (should) take the tag numbers for the offsets.
@Smurf-IV
The right list will be leading as that is how thee Dictionary is created.

[giduac]

A Bi-Directional map should take care of identifying what is what (They have been used for other "Sources of truth" as well)

@Smurf-IV
The PaletteMode enum is used a lot to retrieve the index and that is where things are out of sync atm.
Since the PaletteMode starts with the Global entry the theme index is currently 1 off (if the order was correct).
Therefore PaletteMode will be started with a value of Global = -1. And next the entry is the first theme which will receive the value 0. Which is a valid index.

Also the three theme selector controls will be hooked up to the KManager change event so all stays in sync when a theme is changed from outside the theme selector controls.

I suggest to first make this for alpha and then we can see how much of that will fit in V85 or is desirable.

[giduac]

@Wagnerp

Please close as this has been fixed and completed.
Thanks.