Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other Issues]: Source contains licensing code #633

Closed
giduac opened this issue Feb 7, 2022 · 7 comments
Closed

[Other Issues]: Source contains licensing code #633

giduac opened this issue Feb 7, 2022 · 7 comments
Labels
completed This issue has been completed. discussion Discussion thread. other All other issues.
Milestone

Comments

@giduac
Copy link
Contributor

giduac commented Feb 7, 2022

Hi there,

I came, by accident, across some code that probably was used for licensed features in the original product from Component Factory.
It might be useful to remove this redundant code since there's no use for it currently.

Searched "EncryptedLicenseProvider" in *.cs files

-   Standard-Toolkit-alpha\Source\Krypton Components\Krypton.Ribbon\View Layout Demo\ViewLayoutRibbonAppButton.cs
	Line 130:             EncryptedLicenseProvider.SetParameters(_licenseParameters);
-   Standard-Toolkit-alpha\Source\Krypton Components\Krypton.Ribbon\View Layout Demo\ViewLayoutRibbonAppTab.cs
 	Line 89:             EncryptedLicenseProvider.SetParameters(_licenseParameters);
-   Standard-Toolkit-alpha\Source\Krypton Components\Krypton.Workspace\Palette Demo\WorkspacePageMenuBase.cs
 	Line 40:             EncryptedLicenseProvider.SetParameters(_licenseParameters);

Cheers,

@ghost ghost assigned PWagner1 Feb 7, 2022
@PWagner1
Copy link
Contributor

PWagner1 commented Feb 7, 2022

Hi @giduac Thanks for posting, will remove soon! :)

@PWagner1 PWagner1 transferred this issue from Krypton-Suite/Extended-Toolkit Feb 7, 2022
@PWagner1 PWagner1 added discussion Discussion thread. other All other issues. labels Feb 7, 2022
@PWagner1 PWagner1 added this to the April 2022 milestone Feb 7, 2022
@PWagner1
Copy link
Contributor

PWagner1 commented Feb 7, 2022

@Smurf-IV Are these all in the demo repo?

@giduac
Copy link
Contributor Author

giduac commented Feb 7, 2022

Also found (just looked) in the master repo

@PWagner1
Copy link
Contributor

PWagner1 commented Feb 7, 2022

@Smurf-IV Why are there is there a folder for a installer?

image

@Smurf-IV
Copy link
Member

Smurf-IV commented Feb 7, 2022

@Smurf-IV Why are there is there a folder for a installer?

No idea, Are they in 4.80 ?

@PWagner1
Copy link
Contributor

PWagner1 commented Feb 7, 2022

@Smurf-IV Looks like these files are redundant if you look at them

PWagner1 added a commit that referenced this issue Feb 10, 2022
@PWagner1 PWagner1 added the completed This issue has been completed. label Feb 10, 2022
@PWagner1 PWagner1 removed their assignment Feb 10, 2022
@PWagner1
Copy link
Contributor

Resolved - 10/02/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This issue has been completed. discussion Discussion thread. other All other issues.
Projects
None yet
Development

No branches or pull requests

3 participants