Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Double click on the Form1 file in the Krypton toolkit test project results in a designer error #982

Closed
Smurf-IV opened this issue Mar 25, 2023 · 21 comments
Labels
area:toolkit All issues related to the toolkit components. bug Something isn't working fixed This issue has been fixed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS.

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Mar 25, 2023

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  • Get "Todays" alpha branch of the toolkit (2023-04-25)
  • Build Debug in Visual Studio 2022 (I'm using 17.6 P2)
  • Open the included Test form project and double click the Form1.cs file
    • image

Expected behaviour

  • For the designer to load

Screenshots
image
(The above is stuck in a loop if you click ignore - about 100 times I tried - and also by pressing and holding "Alt+I" !!)

When attaching a Debugger (via retry) you see this:
image

Attempting to run the "TestForm" app results in these (Again holding "Alt+I" results in loads of these pairs!!)

  • image
  • image

I suspect it is something to do with the Toolbar buttons

@Smurf-IV Smurf-IV added bug Something isn't working regression Something was working in a previous release, but isn't working now. labels Mar 25, 2023
@PWagner1
Copy link
Contributor

The 'new' buttonspecs aren't invoked. @Smurf-IV Does this happen for all themes?

@PWagner1 PWagner1 added the under investigation This bug/issue is currently under investigation. label Mar 25, 2023
@PWagner1 PWagner1 added this to the Version 8 milestone Mar 25, 2023
@Smurf-IV
Copy link
Member Author

Smurf-IV commented Mar 25, 2023

The 'new' buttonspecs aren't invoked. @Smurf-IV Does this happen for all themes?

No idea, Just cannot use the "TestForm" project in any way !
I'm just about to go to the Toolkit examples next to see if affects them.

Update:

  • I can load the Toolkit examples
  • This is from the Form example:
    • image

@PWagner1
Copy link
Contributor

Easy Resharper fix

image

@Smurf-IV
Copy link
Member Author

Easy Resharper fix

It'll still throw the Debug.Assert in the designer !!

@PWagner1
Copy link
Contributor

Easy Resharper fix

It'll still throw the Debug.Assert in the designer !!

Could it also be something to do with Source\Krypton Components\Krypton.Toolkit\Values\IntegratedToolBarValues.cs?

@PWagner1
Copy link
Contributor

@Smurf-IV Think I got it now, school boy error, I forgot to 'add' the images to the base palettes!

@PWagner1
Copy link
Contributor

Update: Got Form1 back to a working state, but it's bugged when using O2k13

PWagner1 added a commit that referenced this issue Mar 25, 2023
@PWagner1 PWagner1 mentioned this issue Mar 25, 2023
@PWagner1
Copy link
Contributor

Going back to Canary as the last known 'good' build

@PWagner1
Copy link
Contributor

PWagner1 commented Jul 7, 2023

@Smurf-IV Is there a way to write assert messages out to log files, so I can properly read them, rather than having them truncated?

image

@Smurf-IV
Copy link
Member Author

Smurf-IV commented Jul 7, 2023

Clicking retry will got Visual Studio, and then the stack trace will be available in the CallStack window

@Smurf-IV
Copy link
Member Author

image
https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.defaulttracelistener?view=net-7.0

@Smurf-IV
Copy link
Member Author

Note: The designer appears to be working with o2k13 white now.

@PWagner1
Copy link
Contributor

image https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.defaulttracelistener?view=net-7.0

@Smurf-IV Might be good to enable this for Canary & Nightly configurations only. Maybe a new feature request?

@Smurf-IV
Copy link
Member Author

Should not be part of the Framework, as this is an Application setting. And Some OS's are not even on the C: drive (See Chinese default drive usages)

@PWagner1 PWagner1 modified the milestones: Version 8, Backlog Sep 22, 2023
@PWagner1 PWagner1 added the ongoing This issue is ongoing. label Sep 22, 2023
@giduac
Copy link
Contributor

giduac commented Jun 18, 2024

Hi @Wagnerp & @Smurf-IV,

Is this still a problem since then TestForm has undergone quite a few changes....?

@PWagner1
Copy link
Contributor

Hi @Wagnerp & @Smurf-IV,

Is this still a problem since then TestForm has undergone quite a few changes....?

Hi @giduac

I don't know... are you able to repeat the steps above?

@giduac
Copy link
Contributor

giduac commented Jun 18, 2024

@Wagnerp
You have a try and double click form1 ....

@PWagner1
Copy link
Contributor

@Wagnerp You have a try and double click form1 ....

@giduac

Seems to be working as of v85...

@giduac
Copy link
Contributor

giduac commented Jun 18, 2024

@Wagnerp
And in alpha as mentioned in the call there's no form1.
This one can be put to bed I guess...

@PWagner1
Copy link
Contributor

@Wagnerp And in alpha as mentioned in the call there's no form1. This one can be put to bed I guess...

@giduac

I'll put it as part of v85 and close it

@PWagner1 PWagner1 modified the milestones: Backlog, Version 85 Jun 18, 2024
@PWagner1 PWagner1 added fixed This issue has been fixed. area:toolkit All issues related to the toolkit components. version:85-lts All things to do with V85 LTS. and removed under investigation This bug/issue is currently under investigation. ongoing This issue is ongoing. labels Jun 18, 2024
@giduac
Copy link
Contributor

giduac commented Jun 21, 2024

@Wagnerp
Says fixed...Please close, ty.

@PWagner1 PWagner1 removed their assignment Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:toolkit All issues related to the toolkit components. bug Something isn't working fixed This issue has been fixed. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS.
Projects
None yet
Development

No branches or pull requests

3 participants