Skip to content

Commit

Permalink
CHANGE(client): Disable RNNoise by default
Browse files Browse the repository at this point in the history
In the 1.4.230 release, we enabled RNNoise by default as there have been
lots of reports of how well it works. However, after the release we saw
numerous reports complaining about bad audio quality, which was traced
back to having RNNoise enabled.

For some reason the outcome of having RNNoise enabled is very different
in different scenarios. Sometimes it works miraculously well and other
times it worsens the audio quality to an unbearable level.

There seems to be a higher chance of RNNoise messing up, when using
Windows, but the same effect has also been observed on Linux. It might
also depend on the quality of the used microphone (better quality = less
noise => RNNoise starts doing weird stuff), but we don't have any
definitive clues yet.

Because of this, we will change the default noise cancelling mode back
to Speex so that everyone for whom RNNoise actually works, cna enable
it, but we don't kill the experience for many folks by using an
unsuitable default value.

Fixes mumble-voip#5448

(cherry picked from commit 73adfce)
  • Loading branch information
Krzmbrzl committed May 25, 2022
1 parent eb24589 commit 505dd6e
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions src/mumble/Settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -326,14 +326,10 @@ Settings::Settings() {
iVoiceHold = 50;
iJitterBufferSize = 1;
iFramesPerPacket = 2;
#ifdef USE_RNNOISE
noiseCancelMode = NoiseCancelRNN;
#else
noiseCancelMode = NoiseCancelSpeex;
#endif
iSpeexNoiseCancelStrength = -30;
bAllowLowDelay = true;
uiAudioInputChannelMask = 0xffffffffffffffffULL;
noiseCancelMode = NoiseCancelSpeex;
iSpeexNoiseCancelStrength = -30;
bAllowLowDelay = true;
uiAudioInputChannelMask = 0xffffffffffffffffULL;

// Idle auto actions
iIdleTime = 5 * 60;
Expand Down

0 comments on commit 505dd6e

Please sign in to comment.