Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CHANGE(client): Disable RNNoise by default
In the 1.4.230 release, we enabled RNNoise by default as there have been lots of reports of how well it works. However, after the release we saw numerous reports complaining about bad audio quality, which was traced back to having RNNoise enabled. For some reason the outcome of having RNNoise enabled is very different in different scenarios. Sometimes it works miraculously well and other times it worsens the audio quality to an unbearable level. There seems to be a higher chance of RNNoise messing up, when using Windows, but the same effect has also been observed on Linux. It might also depend on the quality of the used microphone (better quality = less noise => RNNoise starts doing weird stuff), but we don't have any definitive clues yet. Because of this, we will change the default noise cancelling mode back to Speex so that everyone for whom RNNoise actually works, cna enable it, but we don't kill the experience for many folks by using an unsuitable default value. Fixes mumble-voip#5448 (cherry picked from commit 73adfce)
- Loading branch information