Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use android viewBindings #2

Closed
KunalRaghav opened this issue Sep 26, 2021 · 13 comments
Closed

Use android viewBindings #2

KunalRaghav opened this issue Sep 26, 2021 · 13 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@KunalRaghav
Copy link
Owner

Migrate from findViewById to android viewBindings in MainActivity.kt.

Note:

  • Ensure no unnecessary dependencies are added
  • MainActivity.kt and activity_main.xml have minimal changes made to it and are well-formatted before creating a PR.
@KunalRaghav KunalRaghav added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest up-for-grabs labels Sep 26, 2021
@yoobi
Copy link

yoobi commented Sep 28, 2021

Hello, I'd like to work on this one

@KunalRaghav
Copy link
Owner Author

Okay @yoobi I'll assign it to you then

@yoobi
Copy link

yoobi commented Sep 29, 2021

You should consider using resource files for strings

@vilgad
Copy link

vilgad commented Oct 1, 2021

is this issue still open? i would like to solve it

@yoobi
Copy link

yoobi commented Oct 1, 2021

Hello the issue is already assigned and solved

@vilgad
Copy link

vilgad commented Oct 1, 2021

Hello the issue is already assigned and solved
ok

@vilgad
Copy link

vilgad commented Oct 1, 2021

i think the code has not been merged yet because view binding is not applied @yoobi @KunalRaghav

@yoobi
Copy link

yoobi commented Oct 1, 2021

Yes the pull request has not been merged, you can see all current pull request here: https://github.com/KunalRaghav/CrossFire/pulls

@vilgad
Copy link

vilgad commented Oct 1, 2021

Means i should fork your editing and then proceed or it will be ok if i fork original one @yoobi

@yoobi
Copy link

yoobi commented Oct 1, 2021

What are you trying to do ? If you are trying to fix an issue it's better to look in no PR are open for this issue, then fork the project and create your pull request

@vilgad
Copy link

vilgad commented Oct 1, 2021

I wanna add a question so what should I do for this

@yoobi
Copy link

yoobi commented Oct 1, 2021

Okay to add a question you need to:

  1. Fork the project
  2. Add your question in the Question.kt as specified in Add more questions #1
  3. Push your code onto your forked project
  4. Go to your forked project and click on "Create Pull Request"
  5. Fill with a comment to say what you've changed and which issue you're fixing

That's it

@vilgad
Copy link

vilgad commented Oct 1, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

3 participants