-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use android viewBindings #2
Comments
Hello, I'd like to work on this one |
Okay @yoobi I'll assign it to you then |
You should consider using resource files for strings |
is this issue still open? i would like to solve it |
Hello the issue is already assigned and solved |
|
i think the code has not been merged yet because view binding is not applied @yoobi @KunalRaghav |
Yes the pull request has not been merged, you can see all current pull request here: https://github.com/KunalRaghav/CrossFire/pulls |
Means i should fork your editing and then proceed or it will be ok if i fork original one @yoobi |
What are you trying to do ? If you are trying to fix an issue it's better to look in no PR are open for this issue, then fork the project and create your pull request |
I wanna add a question so what should I do for this |
Okay to add a question you need to:
That's it |
Thanks |
Migrate from
findViewById
to android viewBindings inMainActivity.kt
.Note:
MainActivity.kt
andactivity_main.xml
have minimal changes made to it and are well-formatted before creating a PR.The text was updated successfully, but these errors were encountered: