Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Resize only works on some layouts #740

Closed
NireBryce opened this issue Apr 8, 2024 · 2 comments
Closed

[BUG]: Resize only works on some layouts #740

NireBryce opened this issue Apr 8, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@NireBryce
Copy link
Contributor

NireBryce commented Apr 8, 2024

Describe the bug
EDIT: this exists in today's build too.

Only some layouts obey resize commands, but the documentation doesn't reflect that.

To Reproduce

  1. try to use komorebic resize-axis or resize-edge
  2. it fails
  3. switch workspace layout
  4. eventually you find one where it works

Expected behavior
override layout rules and resize the window (and other windows to fit)

Operating System
Output of systeminfo | grep "^OS Name\|^OS Version":

OS Name:                   Microsoft Windows 11 Home
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\<user>
Looking for configuration files in C:\Users\<user>

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\<user>\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

Additional context
the windows seem to vibrate when you try to resize them in 'locked' configuration.

@NireBryce NireBryce added the bug Something isn't working label Apr 8, 2024
@LGUG2Z
Copy link
Owner

LGUG2Z commented Apr 8, 2024

I'll update the docs to reflect this. I don't have any immediate plans to implement resizing for other layouts, but I'm happy to accept PRs that implement it (good example for people who are interested in working on this: #545)

@LGUG2Z
Copy link
Owner

LGUG2Z commented May 12, 2024

a2e9a46

@LGUG2Z LGUG2Z closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants