Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow estimate to run without redshift #50

Merged
merged 1 commit into from
May 17, 2024

Conversation

raphaelshirley
Copy link
Collaborator

@raphaelshirley raphaelshirley commented May 16, 2024

Closes #49

Allow running of estimate without redshift

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@raphaelshirley raphaelshirley requested a review from drewoldag May 16, 2024 23:46
@raphaelshirley raphaelshirley changed the title Update lephare.py Allow estimate to run without redshift May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 46.03%. Comparing base (822f486) to head (03ba798).

Files Patch % Lines
src/rail/estimation/algos/lephare.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   47.15%   46.03%   -1.13%     
==========================================
  Files           2        2              
  Lines         123      126       +3     
==========================================
  Hits           58       58              
- Misses         65       68       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable enough, given that this is an internal method. This might be a good place to add some more tests down the line.

@raphaelshirley raphaelshirley merged commit 5137235 into main May 17, 2024
5 of 7 checks passed
@raphaelshirley raphaelshirley deleted the raphaelshirley-patch-1 branch May 17, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimation doesn't work when input file doesn't have redshift column
2 participants