Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadatatype is not always preserved #54

Closed
kosloot opened this issue Sep 8, 2023 · 1 comment
Closed

metadatatype is not always preserved #54

kosloot opened this issue Sep 8, 2023 · 1 comment
Assignees
Labels

Comments

@kosloot
Copy link
Contributor

kosloot commented Sep 8, 2023

Given this simple FoLiA document:

<?xml version="1.0" encoding="UTF-8"?>
<FoLiA xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://ilk.uvt.nl/folia" xml:id="id.1" generator="libfolia-v2.16" version="2.5.1">
  <metadata type="internal">
    <annotations/>
  </metadata>
  <speech xml:id="speech.1"/>
</FoLiA>

folialint accepts this, but produces:

<?xml version="1.0" encoding="UTF-8"?>
<FoLiA xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://ilk.uvt.nl/folia" xml:id="id.1" generator="libfolia-v2.16" version="2.5.1">
  <metadata type="native">
    <annotations/>
...

NOTE the change in metadata type!

foliavalidator produces:

<?xml version='1.0' encoding='utf-8'?>
<FoLiA xmlns="http://ilk.uvt.nl/folia" xmlns:xlink="http://www.w3.org/1999/xlink" xml:id="id.1" version="2.5.1" generator="foliapy-v2.5.8">
  <metadata type="internal">
    <annotations>
...

so it preserves the metadata type attribute.
@proycon I assume that is the correct behavior?

@kosloot kosloot added the bug label Sep 8, 2023
kosloot added a commit that referenced this issue Sep 13, 2023
@kosloot
Copy link
Contributor Author

kosloot commented Sep 13, 2023

fix seems OK

@kosloot kosloot closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants