Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master key fingerprint requires unrestricted derivation path #290

Open
miketlk opened this issue Nov 12, 2024 · 0 comments
Open

Master key fingerprint requires unrestricted derivation path #290

miketlk opened this issue Nov 12, 2024 · 0 comments

Comments

@miketlk
Copy link

miketlk commented Nov 12, 2024

Description

For security reasons, the application would benefit from restricting the derivation paths available to it. While the current app database format allows specifying unrestricted access with "path": [null], a more secure configuration would specify explicit derivation paths, such as "path": ["44'/1'", "48'/1'", "49'/1'", "84'/1'", "86'/1'"]. However, the SDK currently lacks a function to return the master key fingerprint directly, forcing the app to derive the master pubkey instead.

Proposed Solution

Introduce a dedicated SDK function to return the 32-bit master key fingerprint without requiring the derivation of the master public key on the app's side. This would allow for more secure path restriction by eliminating the need for "path": [null] and to align the app database records with the current wallet apps' security requirements.

Remark

The corresponding Issue #821 was created in the ledger-secure-sdk to ask for this feature. If SDK maintainers consider that addition, this issue in the ledger-app-database could be closed as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant