Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keypair lib #12

Merged
merged 41 commits into from
Apr 15, 2021
Merged

Keypair lib #12

merged 41 commits into from
Apr 15, 2021

Conversation

pasfranc
Copy link
Collaborator

Keypair lib is a npm library that is covering these use cases:

As a user When I answer to personal questions I expect to have a keypair
As a developer I should be able to configure the library with custom questions
As a developer I should be able to configure the backend password via Envirement Variable
As a user I should be able to see the personal questions and reply to them
As a user I after I answered to the personal question I should be able to see if they are correct
As a developer I want to define the personal information for the first generation (email, username, phone number)
As a user When I answer to the personal questions, I don't want to bother about CaseSensitivity and spaces

pasfranc added 23 commits April 13, 2021 14:44
puria
puria requested changes Apr 15, 2021
View reviewed changes
Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this is all for now ;) all minor issues, overall very good IMHO. Looking forward the changes to have successful running tests ✅

package.json Outdated Show resolved Hide resolved
zencode/Keypair-Creation-Client-Side.keys Outdated Show resolved Hide resolved
src/service/fileService.ts Outdated Show resolved Hide resolved
src/serverSide.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/clientSide.ts Outdated Show resolved Hide resolved
@pasfranc pasfranc requested a review from puria April 15, 2021 11:10
This was linked to issues Apr 15, 2021
As a user When I answer to personal questions I expect to have a keypair #9
Closed
As a developer I should be able to configure the library with custom questions #7
Closed
As a developer I should be able to configure the backend password via Envirement Variable #6
Closed
As a user I should be able to see the personal questions and reply to them #5
Closed
As a user I after I answered to the personal question I should be able to see if they are correct #4
Closed
As a developer I want to define the personal information for the first generation (email, username, phone number) #2
Closed
As a user When I answer to the personal questions, I don't want to bother about CaseSensitivity and spaces #1
Closed
@puria puria removed a link to an issue Apr 15, 2021
As a user When I answer to personal questions I expect to have a keypair #9
Closed
@puria puria linked an issue Apr 15, 2021 that may be closed by this pull request
As a user When I answer to personal questions I expect to have a keypair #9
Closed
puria
puria approved these changes Apr 15, 2021
View reviewed changes
src/service/fileService.ts Outdated Show resolved Hide resolved
@puria puria merged commit 4c5ed04 into main Apr 15, 2021
github-actions bot pushed a commit that referenced this pull request Apr 19, 2021
@semantic-release-bot
chore(release): 🚀 1.0.0 [skip ci]
bf28d8c 
# 1.0.0 (2021-04-19)

### Features

* Initial implementation ([#12](#12)) ([4c5ed04](4c5ed04))
@puria
Copy link
Member

puria commented Apr 19, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@puria puria added the released label Apr 19, 2021
@puria puria deleted the keypair_lib branch April 22, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puria puria puria approved these changes

@andrea-dintino andrea-dintino Awaiting requested review from andrea-dintino

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@pasfranc @puria