Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-theme-minimal-blog]: Comments in MDX code blocks are with different size than other elements on iOS devices #414

Closed
belev opened this issue Jun 7, 2020 · 4 comments · Fixed by #421
Labels
type: bug An issue or pull request relating to a bug

Comments

@belev
Copy link

belev commented Jun 7, 2020

Description

When using a longer comment in MDX code blocks, the font size and height of the comment are not with proper size. The comment is bigger than every other texts

Steps to reproduce

Add a longer comment in some MDX code block. For example // some comment here but if it is long enough it is broken"

Expected result

The size of the comment should be with the size of all other text.

Actual result

Size of the comment is not with the same size. In the screenshot below can be seen better:
Screenshot 2020-06-07 at 17 23 15

@belev belev added the type: bug An issue or pull request relating to a bug label Jun 7, 2020
@LekoArts LekoArts added needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting. and removed type: bug An issue or pull request relating to a bug labels Jun 9, 2020
@LekoArts
Copy link
Owner

LekoArts commented Jun 9, 2020

Hi, thanks for the issue!

I followed your reproduction steps but don't see anything wrong?

image

Can you please share a reproduction project where I'd see this behavior?

@belev
Copy link
Author

belev commented Jun 9, 2020

Hi,

Yes, sure. The problem occurs only on iOS device (I tested it on iPhone 7). It can be tested on simulator, it was reproducible there as well.

Please let me know if this helps or if I should provide more information.

@LekoArts LekoArts added type: bug An issue or pull request relating to a bug and removed needs reproduction This issue needs a simplified reproduction of the bug for further troubleshooting. labels Jun 11, 2020
@LekoArts
Copy link
Owner

Fixed in @lekoarts/[email protected]

@belev
Copy link
Author

belev commented Jun 11, 2020

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants