Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant column selections #3694

Closed
dullbananas opened this issue Jul 22, 2023 · 1 comment · Fixed by #3755
Closed

Redundant column selections #3694

dullbananas opened this issue Jul 22, 2023 · 1 comment · Fixed by #3755
Labels
area: database enhancement New feature or request

Comments

@dullbananas
Copy link
Collaborator

dullbananas commented Jul 22, 2023

For example, the post and post_saved tables both have columns for the post id, and both of these columns are selected in post_view because post_saved::all_columns is used. Selecting less columns will speed up compile time (#3610).

diesel-rs/diesel#3223 (comment)

Edit: selecting less columns did not speed up compile time

@dullbananas
Copy link
Collaborator Author

It might also be good to avoid selection of columns with an already known value, such as post_saved::person_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: database enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants