Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChapterListItem is expensive to render #75

Closed
Ligerx opened this issue Jun 9, 2019 · 1 comment · Fixed by #115
Closed

ChapterListItem is expensive to render #75

Ligerx opened this issue Jun 9, 2019 · 1 comment · Fixed by #115

Comments

@Ligerx
Copy link
Owner

Ligerx commented Jun 9, 2019 •
edited
Loading

related to issue #61 and PR #74

the virtualized list doesn't fully solve the chapter list issue. Each ChapterListItem is still super expensive to render and I'm going to open another issue specifically to explore this.

It would be nice to test a production build just to see if it's any better.
I can also try the react devtools profiler, but not sure how useful that will be here.
@Ligerx
Copy link
Owner Author

Ligerx commented Oct 5, 2019

Did some exploration work. Some super messy notes here https://gist.github.com/Ligerx/f9f9f81dca3246f62a981c411b8f46ab

Since the original code was really old and not great, I did some minor refactoring. But nothing big has changed.

@Ligerx Ligerx mentioned this issue Oct 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor refactor of chapter list Ligerx/TachiWeb-React
1 participant
@Ligerx