-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations #434
Comments
Any help needed with this issue? I am happy to help. 😄 |
@hassiahk Yes! I just added the steps to contribute to the above comment, so it'd be great if you follow them and submit a PR! :] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @akihironitta, I'd love to help with this :) Should I just pick one and create a PR? |
@briankosw Yes! Thank you! |
Hey @briankosw. Yes, you can pick one and create a PR for it. 😄 Just leave a comment here saying you picked up this submodule, so you won't clash with others. |
I guess I'll work on |
@akihironitta, I will be working on |
I'm going to work on |
@johnpeterson123 Thank you for your contribution! |
I am interested in working on |
🚀 Feature
As static type checker
mypy
was added in #433, we can add type annotations to the codebase.Steps to contribute
For each PR:
mypy
Progress
pl_bolts.callbacks.*
(add types in bolts/callbacks #444)pl_bolts.datamodules.*
(Adding types to some of datamodules #462)pl_bolts.datasets.*
pl_bolts.losses.*
pl_bolts.metrics.*
pl_bolts.models.*
pl_bolts.models.autoencoders.*
pl_bolts.models.detection.*
pl_bolts.models.gans.*
pl_bolts.models.regression.*
pl_bolts.models.rl.*
pl_bolts.models.self_supervised.*
pl_bolts.models.vision.*
pl_bolts.optimizers.*
pl_bolts.transforms.*
pl_bolts.utils.*
(Add Type Annotations to pl_bolts/utils/* #455)tests.*
The text was updated successfully, but these errors were encountered: