Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❄️: wrap fast load toggle in separate container to fix alignment #1689

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

merryman
Copy link
Member

Fixed #1655

@merryman merryman requested a review from linusha December 19, 2024 17:44
@linusha
Copy link
Contributor

linusha commented Feb 4, 2025

@merryman I can confirm that this works and will thus approve it.
However, I am not entirely clear as to why it works? Could you give me a short rundown either here or in person. I might would like to file this, as I do not think this solution is particularly pretty and I don't think I'd like to force this upon users of the system.

@merryman
Copy link
Member Author

merryman commented Feb 4, 2025

@linusha The trick is to let the layouts handle the alignment instead of manual positioning logic. Here we are again faced with our (failed) attempt to make layouting logic synchronous in morphic. In this case the text layout of the toggle is not yet fully computed at the time we try to position it on load of the landing page. We then end up with this weirdly off fast load toggle described in the issue.

@merryman merryman merged commit b7fec31 into main Feb 4, 2025
4 checks passed
@merryman merryman deleted the fix/landing-page-button branch February 4, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastLoad settings button is layouted wrongly on initial load
2 participants