From 064b73185c14681b249566547441ce19a27d7386 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 2 Jun 2023 14:04:00 +0200 Subject: [PATCH 01/15] Code styling --- Lombiq.Analyzers/Build.props | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Lombiq.Analyzers/Build.props b/Lombiq.Analyzers/Build.props index 34021ccb..085a837a 100644 --- a/Lombiq.Analyzers/Build.props +++ b/Lombiq.Analyzers/Build.props @@ -2,10 +2,10 @@ $(MSBuildThisFileDirectory)orchardcore.ruleset true - false + From 6223f11ec463912bfffe139ca919a3632d9a2cf0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 2 Jun 2023 14:07:05 +0200 Subject: [PATCH 02/15] Updating to latest analyzer packages --- Lombiq.Analyzers/CommonPackages.props | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Lombiq.Analyzers/CommonPackages.props b/Lombiq.Analyzers/CommonPackages.props index 1054d28e..d6ac2c4b 100644 --- a/Lombiq.Analyzers/CommonPackages.props +++ b/Lombiq.Analyzers/CommonPackages.props @@ -6,12 +6,12 @@ - - - - + + + + - + From 0d6959af34bfc1d73436f4ee703c2a6a76f4edc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Fri, 2 Jun 2023 16:25:46 +0200 Subject: [PATCH 03/15] Disabling "S1133 Do not forget to remove this deprecated code someday." as it's not really useful --- Lombiq.Analyzers/general.ruleset | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Lombiq.Analyzers/general.ruleset b/Lombiq.Analyzers/general.ruleset index 23852a19..f0f5b84b 100644 --- a/Lombiq.Analyzers/general.ruleset +++ b/Lombiq.Analyzers/general.ruleset @@ -330,7 +330,7 @@ - + @@ -386,7 +386,6 @@ - @@ -399,7 +398,6 @@ - From 220f49cf0c30023b852864c5fa0d57a3adf58d8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 4 Jun 2023 21:03:34 +0200 Subject: [PATCH 04/15] Upgrading to C# 11 --- Lombiq.Analyzers/Build.props | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lombiq.Analyzers/Build.props b/Lombiq.Analyzers/Build.props index 085a837a..c793abd9 100644 --- a/Lombiq.Analyzers/Build.props +++ b/Lombiq.Analyzers/Build.props @@ -13,10 +13,10 @@ strict - 10.0 + 11.0 - 6.0 + 7.0 From 65b3f8261444b84c0dcdc4184d00451caa2314b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Sun, 4 Jun 2023 21:38:08 +0200 Subject: [PATCH 05/15] Fixing NuGet publishing --- Lombiq.Analyzers/Lombiq.Analyzers.csproj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Lombiq.Analyzers/Lombiq.Analyzers.csproj b/Lombiq.Analyzers/Lombiq.Analyzers.csproj index 1213acb3..29143f72 100644 --- a/Lombiq.Analyzers/Lombiq.Analyzers.csproj +++ b/Lombiq.Analyzers/Lombiq.Analyzers.csproj @@ -3,6 +3,9 @@ netstandard2.0 $(DefaultItemExcludes);.git*; + + License.md + throw a warning. See https://github.com/Lombiq/GitHub-Actions/issues/236. --> License.md From 493110302c4ebf72ea2c253005669b2c639e1fc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 5 Jun 2023 15:57:50 +0200 Subject: [PATCH 07/15] Fixing comment --- Lombiq.Analyzers/Build.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Analyzers/Build.props b/Lombiq.Analyzers/Build.props index c793abd9..44da018e 100644 --- a/Lombiq.Analyzers/Build.props +++ b/Lombiq.Analyzers/Build.props @@ -2,10 +2,10 @@ $(MSBuildThisFileDirectory)orchardcore.ruleset true - false + false From 5978b203081c46edf2a5d1c942a6a8c63b281aba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 5 Jun 2023 16:02:06 +0200 Subject: [PATCH 08/15] Restoring deleted lines that shouldn't necessarily be deleted --- Lombiq.Analyzers/general.ruleset | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Lombiq.Analyzers/general.ruleset b/Lombiq.Analyzers/general.ruleset index f0f5b84b..5699f6b0 100644 --- a/Lombiq.Analyzers/general.ruleset +++ b/Lombiq.Analyzers/general.ruleset @@ -330,6 +330,7 @@ + @@ -386,6 +387,7 @@ + @@ -398,6 +400,7 @@ + From c904c0afd1b6de3368fa1cebd05bbeb2a6c528a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Mon, 5 Jun 2023 19:36:56 +0200 Subject: [PATCH 09/15] Updating Meziantou.Analyzer to v2.0.58 --- Lombiq.Analyzers/CommonPackages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Analyzers/CommonPackages.props b/Lombiq.Analyzers/CommonPackages.props index d6ac2c4b..8795d318 100644 --- a/Lombiq.Analyzers/CommonPackages.props +++ b/Lombiq.Analyzers/CommonPackages.props @@ -6,7 +6,7 @@ - + From 5d70aef6595922a567269cf99d843e71a63034e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Tue, 6 Jun 2023 16:46:10 +0200 Subject: [PATCH 10/15] Updating Meziantou.Analyzer to v2.0.59 with fix for https://github.com/meziantou/Meziantou.Analyzer/issues/545 --- Lombiq.Analyzers/CommonPackages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Analyzers/CommonPackages.props b/Lombiq.Analyzers/CommonPackages.props index 8795d318..d2321207 100644 --- a/Lombiq.Analyzers/CommonPackages.props +++ b/Lombiq.Analyzers/CommonPackages.props @@ -6,7 +6,7 @@ - + From c3fb12b53e8b5680957645e41cbd24dbc237d044 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Tue, 6 Jun 2023 16:49:34 +0200 Subject: [PATCH 11/15] Updating the test solution to the latest package too --- .../IndirectPackageReference/IndirectPackageReference.csproj | 2 +- .../Lombiq.Analyzers.PackageReference.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj b/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj index 71fcf694..2c10c4d0 100644 --- a/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj +++ b/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj @@ -10,7 +10,7 @@ --> - + all diff --git a/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj b/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj index 2a3b5580..02ab25c0 100644 --- a/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj +++ b/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj @@ -5,7 +5,7 @@ - + all From 518c392336f677d0dda184eedcfb581c3eebe39e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Tue, 6 Jun 2023 16:54:09 +0200 Subject: [PATCH 12/15] Note about publishing to NuGet --- Readme.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Readme.md b/Readme.md index fd3890f2..0022672e 100644 --- a/Readme.md +++ b/Readme.md @@ -46,6 +46,10 @@ Bug reports, feature requests, comments, questions, code contributions and love This project is developed by [Lombiq Technologies](https://lombiq.com/). Commercial-grade support is available through Lombiq. +### Publishing a new NuGet package + +When publishing a new version of the NuGet package, even if it's just a prerelease, also update the package references under _TestSolutions\Lombiq.Analyzers.PackageReferences_ to the new version. This is necessary to run the tests there + ### Upgrading to a new version of the .NET SDK When a new version of the .NET SDK comes out then to the following: From 9235278bc49eb08d37e5fc72aa289c09fdddd816 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Tue, 6 Jun 2023 17:34:41 +0200 Subject: [PATCH 13/15] Updating Meziantou.Analyzer to v2.0.60 --- Lombiq.Analyzers/CommonPackages.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lombiq.Analyzers/CommonPackages.props b/Lombiq.Analyzers/CommonPackages.props index d2321207..f7d07c4e 100644 --- a/Lombiq.Analyzers/CommonPackages.props +++ b/Lombiq.Analyzers/CommonPackages.props @@ -6,7 +6,7 @@ - + From d453a4e9331dfa8997182f9fc44d7fad9ccd935c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Tue, 6 Jun 2023 17:42:07 +0200 Subject: [PATCH 14/15] Updating the test solution to the latest package too --- .../IndirectPackageReference/IndirectPackageReference.csproj | 2 +- .../Lombiq.Analyzers.PackageReference.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj b/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj index 2c10c4d0..7d2c5c56 100644 --- a/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj +++ b/TestSolutions/Lombiq.Analyzers.PackageReference/IndirectPackageReference/IndirectPackageReference.csproj @@ -10,7 +10,7 @@ --> - + all diff --git a/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj b/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj index 02ab25c0..f7217907 100644 --- a/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj +++ b/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj @@ -5,7 +5,7 @@ - + all From 273d790bab3edef7796fa1c5752f053a020f2adf Mon Sep 17 00:00:00 2001 From: 0liver <0liver@users.noreply.github.com> Date: Tue, 6 Jun 2023 21:52:57 +0200 Subject: [PATCH 15/15] Fix grammar --- Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Readme.md b/Readme.md index 0022672e..d1911e3a 100644 --- a/Readme.md +++ b/Readme.md @@ -48,7 +48,7 @@ This project is developed by [Lombiq Technologies](https://lombiq.com/). Commerc ### Publishing a new NuGet package -When publishing a new version of the NuGet package, even if it's just a prerelease, also update the package references under _TestSolutions\Lombiq.Analyzers.PackageReferences_ to the new version. This is necessary to run the tests there +When publishing a new version of the NuGet package, even if it's just a pre-release, also update the package references under _TestSolutions\Lombiq.Analyzers.PackageReferences_ to the new version. This is necessary to run the tests there. ### Upgrading to a new version of the .NET SDK