Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/upload-artifact calls to latest v4 (OSOE-809) #329

Closed
BenedekFarkas opened this issue Feb 13, 2024 · 3 comments
Closed

Upgrade actions/upload-artifact calls to latest v4 (OSOE-809) #329

BenedekFarkas opened this issue Feb 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BenedekFarkas
Copy link
Member

BenedekFarkas commented Feb 13, 2024

As it brings a lot of improvements, see the announcement.

See its usages across the Lombiq organization.

Any particular reason we don't have a wrapper action yet?

Jira issue

@github-actions github-actions bot changed the title Upgrade actions/upload-artifact calls to latest v4 Upgrade actions/upload-artifact calls to latest v4 (OSOE-809) Feb 13, 2024
@BenedekFarkas BenedekFarkas added the enhancement New feature or request label Feb 13, 2024
@Piedone
Copy link
Member

Piedone commented Feb 13, 2024

Duplicate of: #272. I added a note there to also have a wrapper.

@Piedone Piedone closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@BenedekFarkas
Copy link
Member Author

OK then! AFAIK we don't have any usages of it where the time reduction would be of huge impact right now (= not having to wait that much + runner cost). The only exception is a client project that I just upgraded and uploading a 500-something MB artifact took 21 seconds instead of 2 and a half minutes, which is great.

@Piedone
Copy link
Member

Piedone commented Feb 13, 2024

Yeah, that'll be nice but not crucial. Most of our projects only upload artifacts on some failure anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants