Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-and-test-orchard-core workflow fails to upload failure dumps under Windows, if the app contains a file with a long path (OSOE-851) #347

Closed
DemeSzabolcs opened this issue May 13, 2024 · 1 comment · Fixed by Lombiq/UI-Testing-Toolbox#362
Labels
bug Something isn't working

Comments

@DemeSzabolcs
Copy link
Member

DemeSzabolcs commented May 13, 2024

This is a Windows specific issue. I suspect that this is because of the Windows max path length which is ~256 characters.

Example log:

Total tests: 1
     Failed: 1
 Total time: 2.0352 Minutes
Test Run Failed.
Test failed: test\Example-Project.Tests.UI\Example-Project.Tests.UI.csproj
Error: Process completed with exit code 1.
Run Merge-FailureDumps -Directory "."

    Directory: C:\a\Example-Project\Example-Project

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----           5/11/2024  5:50 PM                FailureDumps

Run actions/[email protected]
Error: ENOENT: no such file or directory, realpath 'C:\a\Example-Project\Example-Project\FailureDumps\Example_Project_Tests_UI_Tests_ExamplePage_VisualVerificationTests_VisualVerificationTests_VerifyTheTestPage\Attempt 0\AppDump\Recipes\media\ExampleSite\VehiclePages\GroundVehicles\Cars\BMW\BMW Individual M760Li xDrive Model V12 Excellence`

In this example, there is a folder that contains images inside the Recipes folder. These are always added to the failure dumps. However this path is too long for Windows (it's over ~256 character). In this case nothing happens, nothing is uploaded. So there is no failure dump on GitHub.

Expected behavior: There should be a workaround, to get a failure dump, even with long file paths on Windows. For example: don't upload the files with paths over 256 character, or shorten their folder names (this should be logged though).

Jira issue

@DemeSzabolcs DemeSzabolcs added the bug Something isn't working label May 13, 2024
@github-actions github-actions bot changed the title Fix build-and-test-orchard-core workflow fails to upload failure dumps under Windows, if the app contains a file with a long path Fix build-and-test-orchard-core workflow fails to upload failure dumps under Windows, if the app contains a file with a long path (OSOE-851) May 13, 2024
@Piedone
Copy link
Member

Piedone commented May 13, 2024

Lombiq/UI-Testing-Toolbox#362 fixes this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants