Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open new Jira issue when GitHub discussion is created by a team member (OSOE-390) #59

Open
sarahelsaig opened this issue Oct 2, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@sarahelsaig
Copy link
Member

sarahelsaig commented Oct 2, 2022

Currently the create-jira-issues-for-community-activities action creates a new Jira issue whenever someone opens a new discussion on GH, even if that someone is one of us. (e.g. https://lombiq.atlassian.net/browse/OCC-92) It would be better to avoid that if the discussion creator was a team member who makes announcements. I think we could use one or both of these techniques to get a list of team members:

  • Query the "Collaborators and teams" for the repository, select the members with write access.
  • Add an ignore-discussion-author input to the action and list the team members who'd write announcements (usually the project leader) in the repository's workflow that invokes the action. This has to be manually maintained, but it's practical when the repository might have external contributors that wouldn't have Jira access (e.g. in OCC).

Jira issue

@sarahelsaig sarahelsaig added the enhancement New feature or request label Oct 2, 2022
@github-actions github-actions bot changed the title Don't open new Jira issue when GitHub discussion is created by a team member Don't open new Jira issue when GitHub discussion is created by a team member (OSOE-390) Oct 2, 2022
@Piedone
Copy link
Member

Piedone commented Oct 2, 2022

We don't open issues for reviewing PRs that are related to a Jira issue, because there the review is determined by the issue. However, discussions aren't related to Jira issues, and need attention from the project maintainer in the same way a discussion opened by a third-party does. If the maintainer doesn't know about it, it'll go without responses too. Thus, why would we exclude them?

@sarahelsaig
Copy link
Member Author

sarahelsaig commented Oct 2, 2022

Seems overly cautious to me, but I tend to leave my GH notifications settings very broad so I get a notification anyway. I guess that's up for taste.

However I still think adding an ignore-discussion-author would be a good idea and it should include at least the project leader. This way the action won't generate useless issues when we make announcements.

@Piedone
Copy link
Member

Piedone commented Oct 2, 2022

We can have an ignore list of authors, yes.

@sarahelsaig
Copy link
Member Author

Ok, updated the description accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants