Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run setup-dotnet if the image doesn't contain the same .NET version (OSOE-396) #66

Closed
Piedone opened this issue Oct 12, 2022 · 2 comments · Fixed by #67
Closed

Only run setup-dotnet if the image doesn't contain the same .NET version (OSOE-396) #66

Piedone opened this issue Oct 12, 2022 · 2 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Oct 12, 2022 •
edited by github-actions bot
Loading

Running actions/setup-dotnet takes ~10s under Ubuntu, and ~45s under Windows. We always use it to install version 6.0.*, which is actually pre-installed both under Ubuntu and Windows. Let's not run the installation when the desired version exists.

Also, let's upgrade actions/setup-dotnet to v3, perhaps that already handles this.

Jira issue
@Piedone Piedone added the enhancement New feature or request label Oct 12, 2022
@github-actions github-actions bot changed the title Only run setup-dotnet if the image doesn't contain the same .NET version Only run setup-dotnet if the image doesn't contain the same .NET version (OSOE-396) Oct 12, 2022
@Piedone Piedone mentioned this issue Oct 12, 2022
Merged
@Piedone
Copy link
Member Author

Piedone commented Oct 12, 2022

With v3 this is supposed to be already handled, but doesn't seem so: actions/setup-dotnet#284 (comment)

@Piedone
Copy link
Member Author

Piedone commented Oct 12, 2022

It is, I just misunderstood how it's supposed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Piedone